search

Girbons / comics-downloader

tool to download comics and manga in pdf/epub/cbr/cbz from a website
MIT License
456 stars 49 forks source link

segmentation violation trying to use chapter url instead of manga url #93

Closed Mycah closed 2 years ago

Mycah commented 2 years ago

Describe the bug Downloading single issues with issue links does not work with the new sites (mangakakalot.com/readmanganato.com)

To Reproduce ./comics-downloader -url=https://readmanganato.com/manga-ao977497/chapter-1 or ./comics-downloader -url=https://mangakakalot.com/chapter/jb925486/chapter_22

Expected behavior Issue download

Screenshots

INFO[0000] Downloading...
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x705195]

goroutine 1 [running]:
github.com/anaskhan96/soup.findAllofem.func1(0x0, {0xc000525da0, 0x0, 0x3}, 0x48)
        /Users/girbons/go/pkg/mod/github.com/anaskhan96/soup@v1.2.4/soup.go:534 +0x1d5
github.com/anaskhan96/soup.findAllofem(0x0, {0xc000525da0, 0x3, 0x3}, 0x0)
        /Users/girbons/go/pkg/mod/github.com/anaskhan96/soup@v1.2.4/soup.go:538 +0xe4
github.com/anaskhan96/soup.Root.FindAll({0x0, {0x0, 0x0}, {0x86c240, 0xc0001cc120}}, {0xc000525da0, 0xc0000001a0, 0x43cc45})
        /Users/girbons/go/pkg/mod/github.com/anaskhan96/soup@v1.2.4/soup.go:283 +0x7e
github.com/Girbons/comics-downloader/pkg/sites.MangaKakalotRetrieveIssueLinks({0x7e5af3, 0x10}, {0x7fff85332664, 0x4f4c01})
        /Users/girbons/go/src/github.com/Girbons/comics-downloader/pkg/sites/common.go:75 +0x4b4
github.com/Girbons/comics-downloader/pkg/sites.(*MangaKakalot).RetrieveIssueLinks(0xc00057be00)
        /Users/girbons/go/src/github.com/Girbons/comics-downloader/pkg/sites/mangakakalot.go:31 +0x30
github.com/Girbons/comics-downloader/pkg/sites.LoadComicFromSource(0xc000115900)
        /Users/girbons/go/src/github.com/Girbons/comics-downloader/pkg/sites/loader.go:115 +0x372
github.com/Girbons/comics-downloader/cmd/app.download(0xc000115900)
        /Users/girbons/go/src/github.com/Girbons/comics-downloader/cmd/app/downloader.go:77 +0x305
github.com/Girbons/comics-downloader/cmd/app.Run(0xc000115900)
        /Users/girbons/go/src/github.com/Girbons/comics-downloader/cmd/app/downloader.go:123 +0x170
main.main()
        /Users/girbons/go/src/github.com/Girbons/comics-downloader/cmd/downloader/main.go:90 +0x23c

Desktop (please complete the following information):

Additional context Same error for both sites, but if you link to the main comic page it can download.

Girbons commented 2 years ago

Hey @Jan0660 do you have any clue about this?