Bug in pagination helper code

Girl-Code-It / Opportunity-Calendar-Backend

Opportunity Calendar is the one-stop place to refer important opportunities available in tech-space like newly posted jobs, internships, hackathons, tech-conferences, scholarships, etc.

https://opportunity-calendar.herokuapp.com/

MIT License

15 stars 30 forks source link

Bug in pagination helper code #107

Open Sukriti-sood opened 3 years ago

Sukriti-sood commented 3 years ago

In PAgination Helper Code :-

There are some unnecessary variable used
Logic for total pages is also wrong if (numDocs >= limit) { totalPages = Math.floor(numDocs / limit) + (numDocs % limit); }
It was not filtering Opportunities On the Basis of Opportunity-Type.

This issue has been resolve in PR of GET API TEST #97