Girl-Code-It / Opportunity-Calendar-Backend

Opportunity Calendar is the one-stop place to refer important opportunities available in tech-space like newly posted jobs, internships, hackathons, tech-conferences, scholarships, etc.
https://opportunity-calendar.herokuapp.com/
MIT License
15 stars 30 forks source link

addded onlyForFemale field #63

Closed ritik307 closed 3 years ago

ritik307 commented 3 years ago

Description

Added onlyForFemale field in the following:

Fixes #61

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

ritik307 commented 3 years ago

@Manvityagi plz review

ritik307 commented 3 years ago

Corresponding additions in the documentation have not been done - In routes/opportunity.js in the response of get and in properties of post API documentation.

Corresponding additions in tests have also not been done. Every test should be updated which is affected by this change.

As a rule of thumb, For a backend PR, all the changes should be accompanied by corresponding changes in tests and documentation.

@ritik307

ok got it will do that ASAP

ritik307 commented 3 years ago

@Manvityagi what should I write in the type and description section of the documentation.

Manvityagi commented 3 years ago

@Manvityagi what should I write in the type and description section of the documentation.

Represents if the opportunity is only for females

ritik307 commented 3 years ago

@Manvityagi what should I write in the type and description section of the documentation.

Represents if the opportunity is only for females

The type should be boolean right?

Manvityagi commented 3 years ago

@Manvityagi what should I write in the type and description section of the documentation.

Represents if the opportunity is only for females

Thetype should be boolean right?

Yes

ritik307 commented 3 years ago

@Manvityagi Done with changes Plz check

ritik307 commented 3 years ago

@Manvityagi I have made all the requested changes plz review

ritik307 commented 3 years ago

@Manvityagi THnaks for merging the PR Kindly add the appropriate GSSOC21 tag and level tag to the PR.