Closed ritik307 closed 3 years ago
@Manvityagi plz review
Corresponding additions in the documentation have not been done - In
routes/opportunity.js
in the response ofget
and in properties ofpost
API documentation.Corresponding additions in tests have also not been done. Every test should be updated which is affected by this change.
As a rule of thumb, For a backend PR, all the changes should be accompanied by corresponding changes in tests and documentation.
@ritik307
ok got it will do that ASAP
@Manvityagi what should I write in the type
and description
section of the documentation.
@Manvityagi what should I write in the
type
anddescription
section of the documentation.
Represents if the opportunity is only for females
@Manvityagi what should I write in the
type
anddescription
section of the documentation.Represents if the opportunity is only for females
The type
should be boolean right?
@Manvityagi what should I write in the
type
anddescription
section of the documentation.Represents if the opportunity is only for females
The
type
should be boolean right?
Yes
@Manvityagi Done with changes Plz check
@Manvityagi I have made all the requested changes plz review
@Manvityagi THnaks for merging the PR Kindly add the appropriate GSSOC21 tag and level tag to the PR.
Description
Added
onlyForFemale
field in the following:Fixes #61
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: