added onlyForFemale field

[ritik307]

Description

The GET API currently can now filter on the basis of onlyForFemale field.

Fixes #69

Type of change

Please delete options that are not relevant.

• [x] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [x] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• [ ] Test A
• [ ] Test B

Checklist:

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes
• [x] Any dependent changes have been merged and published in downstream modules

[ritik307]

@Manvityagi Plz review

[ritik307]

1. There are merge conflicts that you need to resolve.

2. I don't see the corresponding updates in `tests`

will fix that asap

[ritik307]

@Manvityagi Done Plz check

[ritik307]

@Manvityagi @abdus Plz review

[Manvityagi]

@ritik307 The build fails on your PR. Run your code & tests locally and fix the issue. You can see the build log by clicking on the Travis details link in checks and see what's causing the build to fail.

[ritik307]

@Manvityagi Plz review

[ritik307]

@Manvityagi Done! Kindly review

[ritik307]

@abdus Done! Plz review

[abdus]

@ritik307 please solve the merge conflict. I aim to accept/reject this PR by this weekend. It has been here for a long time.

[ritik307]

@abdus Plz review Just a matter of fact I always make the requested changes within a day or two but they didn't get a review for weeks.

[abdus]

the pagination thing is missing. I am attaching screenshots so that it's easier for you to understand.

sorry about being late. less free time than before.

[ritik307]

@abdus My task was to add onlyforfemale field.

[abdus]

possibly overridden code blocks that were responsible for pagination? looking at your commit history, it looks like you have removed part of the js-doc.

[ritik307]

possibly overridden code blocks that were responsible for pagination? looking at your commit history, it looks like you have removed part of the js-doc.

can you plz elaborate which js-doc you are talking about?

[ritik307]

@abdus plz review. btw I haven't removed the pagination code as far as I think the pagination code was merged before my issue that could be the reason it's missing from my PR.

[abdus]

did you actually test the code after pushing? the GET for opportunity is missing from swagger. after making changes, please go to localhost:3030/playground and check whether your code is actually working or not.

[abdus]

@ritik307 any updates?

[abdus]

participant inactive. closing...