Girl-Code-It / Opportunity-Calendar-Backend

Opportunity Calendar is the one-stop place to refer important opportunities available in tech-space like newly posted jobs, internships, hackathons, tech-conferences, scholarships, etc.

https://opportunity-calendar.herokuapp.com/

MIT License

15 stars 30 forks source link

DELETE Endpoint added #79

Closed Vishal1003 closed 3 years ago

Vishal1003 commented 3 years ago

Description

I have added the relevant changes (delete method for the opportunities). @abdus Kindly review my changes!

Fixes #74

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

RESPONSE IMAGE -

Manvityagi commented 3 years ago

Any updates @Vishal1003 ?

Vishal1003 commented 3 years ago

@Manvityagi @abdus Sorry for the delay. I have done my task but the getOpportunity tests are failing (don't know why) after I merged with the upstream branch (and I believe there is a separate issue for resolving this).

Kindly review my changes. Thank you!

Manvityagi commented 3 years ago

@Manvityagi @abdus Sorry for the delay. I have done my task but the getOpportunity tests are failing (don't know why) after I merged with the upstream branch (and I believe there is a separate issue for resolving this).

Kindly review my changes. Thank you!

Yeah, you are right. We are figuring what's wrong with it.

Manvityagi commented 3 years ago

@Vishal1003 Pull the latest code, the issue has been fixed

Vishal1003 commented 3 years ago

Have you entered the right credentials in .env? The build fails, seems like a connection to DB could not be established.

@Manvityagi Yes i entered the correct credentials.. I don't know why the build is failing.. (the tests are running fine on my pc).

Manvityagi commented 3 years ago

Have you entered the right credentials in .env? The build fails, seems like a connection to DB could not be established.

@Manvityagi Yes i entered the correct credentials.. I don't know why the build is failing.. (the tests are running fine on my pc).

Take the pull once more, it should work now

Vishal1003 commented 3 years ago

Have you entered the right credentials in .env? The build fails, seems like a connection to DB could not be established.

@Manvityagi Yes i entered the correct credentials.. I don't know why the build is failing.. (the tests are running fine on my pc).

Take the pull once more, it should work now

Done! Kindly review my changes (for issue #74 ) Thank you

Vishal1003 commented 3 years ago

Please do the changes as mentioned in comments

@Manvityagi I have made all the necessary changes.