Girl-Code-It / Opportunity-Calendar-Frontend

Opportunity Calendar is the one-stop place to refer important opportunites available in tech-space like newly posted jobs, internships, hackathons, tech-conferences, scholarhsips etc.

https://cutt.ly/opportunity-calendar

MIT License

49 stars 88 forks source link

Fixed UI gitch and clean up the code #223

Closed Samridhi-98 closed 3 years ago

Samridhi-98 commented 3 years ago

Description

Fixed UI gitch and clean up the code

Fixed #221

Type of change

[x] Fixed alignment in iPad and other modes.
[x] Clean up the code(Removed unnecessary warnings)

Please check options that are relevant to your PR.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] I have pulled the latest changes in the repository
[x] I have squashed my commits
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

Screenshot

image_2021_04_19T15_42_00_915Z

Samridhi-98 commented 3 years ago

@vaishali614 will you please review my PR.

Samridhi-98 commented 3 years ago

Clean up code part looks good, but the cards still are not at the center for many view-ports

Will improve it.

Samridhi-98 commented 3 years ago

@Manvityagi Done! Please check

Manvityagi commented 3 years ago

@Manvityagi Done! Please check

It has improved a lot as compared to the last PR, but there are still some problems with some screen sizes,

See the gif attached

Samridhi-98 commented 3 years ago

@Manvityagi Please check, I have updated all viewports and also removed unnecessary media queries.