Closed Samridhi-98 closed 3 years ago
@vaishali614 @Manvityagi Please review my PR. Also, there is no field for opportunityImage in the mongoose schema but the form section has the state property for the image. Should I remove it from the frontend part or simply open an issue in the backend repository to update the opportunity schema.
@vaishali614 @Manvityagi Please review my PR. Also, there is no field for opportunityImage in the mongoose schema but the form section has the state property for the image. Should I remove it from the frontend part or simply open an issue in the backend repository to update the opportunity schema.
https://github.com/Girl-Code-It/Opportunity-Calendar-Backend/issues/65 Have opened the issue in backend for the same
@vaishali614 @Manvityagi Please review my PR. Also, there is no field for opportunityImage in the mongoose schema but the form section has the state property for the image. Should I remove it from the frontend part or simply open an issue in the backend repository to update the opportunity schema.
Girl-Code-It/Opportunity-Calendar-Backend#65 Have opened the issue in backend for the same
Thank you, Will update this PR as soon as that PR will be merged, till the time I am keeping it as a draft PR.
@vaishali614 @Manvityagi Please review my PR. Also, there is no field for opportunityImage in the mongoose schema but the form section has the state property for the image. Should I remove it from the frontend part or simply open an issue in the backend repository to update the opportunity schema.
Girl-Code-It/Opportunity-Calendar-Backend#65 Have opened the issue in backend for the same
Thank you, Will update this PR as soon as that PR will be merged, till the time I am keeping it as a draft PR.
Sounds good 👍
@vaishali614 @Manvityagi I have updated for image URL please review.
@vaishali614 @Manvityagi I have updated for image URL please review.
@Samridhi-98 I can't post an opportunity.
CC: @Manvityagi
@vaishali614 @Manvityagi I have updated for image URL please review.
@Samridhi-98 I can't post an opportunity.
CC: @Manvityagi
@vaishali614 I am not sure but there is some error at the backend while testing the URL I am not able to retrieve anything, got this error message please let me know how can I fix this.
Screenshot
@vaishali614 @Manvityagi I have updated for image URL please review.
@Samridhi-98 I can't post an opportunity. CC: @Manvityagi
@vaishali614 I am not sure but there is some error at the backend while testing the URL I am not able to retrieve anything, got this error message please let me know how can I fix this.
Screenshot
It should be working now, Please check
@vaishali614 @Manvityagi I have updated for image URL please review.
@Samridhi-98 I can't post an opportunity. CC: @Manvityagi
@vaishali614 I am not sure but there is some error at the backend while testing the URL I am not able to retrieve anything, got this error message please let me know how can I fix this. Screenshot
It should be working now, Please check
Yes, It's working. @vaishali614 please review and let me know if I need to update anything.
@Samridhi-98 The changes look perfect. But, we've added two more fields in the schema: opportunityType, onlyForFemale. Since you've been working on the opportunity form, can you add a dropdown for opportunityType with values JOB, INTERNSHIP, HACKATHON, SCHOLARSHIP, CONFERENCE, CODINGCOMPETITION and a toggle button for onlyForFemale in the form for these two fields? Apart from this, everything looks good.
You can refer to the Swagger Doc here
@Samridhi-98 The changes look perfect. But, we've added two more fields in the schema: opportunityType, onlyForFemale. Since you've been working on the opportunity form, can you add a dropdown for opportunityType with values JOB, INTERNSHIP, HACKATHON, SCHOLARSHIP, CONFERENCE, CODINGCOMPETITION and a toggle button for onlyForFemale in the form for these two fields? Apart from this, everything looks good.
You can refer to the Swagger Doc here
I think we can increase the level of this issue from 2 to 3, if you want to take this added task.
@Samridhi-98 The changes look perfect. But, we've added two more fields in the schema: opportunityType, onlyForFemale. Since you've been working on the opportunity form, can you add a dropdown for opportunityType with values JOB, INTERNSHIP, HACKATHON, SCHOLARSHIP, CONFERENCE, CODINGCOMPETITION and a toggle button for onlyForFemale in the form for these two fields? Apart from this, everything looks good.
You can refer to the Swagger Doc here
Sure, I will add it.
@vaishali614 Do I need to add a dropdown for opportunityType in each form, Since each and every opportunity type has its own separate form so it's pointless to add opportunityType dropdown.
@vaishali614 Do I need to add a dropdown for opportunityType in each form, Since each and every opportunity type has its own separate form so it's pointless to add opportunityType dropdown.
Yeah I agree with you, that's why we're planning to reduce 6 forms into 1 form, so we'll need the dropdown. But for now, just add this dropdown in each form.
@vaishali614 Do I need to add a dropdown for opportunityType in each form, Since each and every opportunity type has its own separate form so it's pointless to add opportunityType dropdown.
Yeah I agree with you, that's why we're planning to reduce 6 forms into 1 form, so we'll need the dropdown. But for now, just add this dropdown in each form.
Okay.
@vaishali614 @Manvityagi Please review.
PS: Please make sure you test it completely before you update your PR for review.
- You are using the same ID twice on the same page
- There's some error on your end while making request. Please check.
PS: Please make sure you test it completely before you update your PR for review.
@vaishali614 I am unable to send the request will you please help me out with this.
Screeenshot
@vaishali614 I have updated as you suggested and each form is properly working please review and let me know if anything else to update.
Description
Updated API in all sections of the post opportunity and code refactoring.
Fixed #229
Type of change
Please check options that are relevant to your PR.
Checklist: