search

Girl-Code-It / Opportunity-Calendar-Frontend

Opportunity Calendar is the one-stop place to refer important opportunites available in tech-space like newly posted jobs, internships, hackathons, tech-conferences, scholarhsips etc.
https://cutt.ly/opportunity-calendar
MIT License
49 stars 88 forks source link

Added navbar in footer for all the pages of Know About #243

Closed RuchiGitHu closed 3 years ago

RuchiGitHu commented 3 years ago

Description

I have added Navbar option in footer of every "KNOW ABOUT" card page. So that after going through it, user can directly move back where they want without backing again and again using browser back. image image

Fixed #240 (issue) (e.g. Fixed #8)

Type of change

Please check options that are relevant to your PR.

Checklist:

RuchiGitHu commented 3 years ago

Description

I have added Navbar option in footer of every "KNOW ABOUT" card page. So that after going through it, user can directly move back where they want without backing again and again using browser back. image image

Fixed #240 (issue) (e.g. Fixed #8)

Type of change

Please check options that are relevant to your PR.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] This change requires a documentation update

Checklist:

  • [x] I have pulled the latest changes in the repository
  • [ ] I have squashed my commits
  • [x] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings

Please review @Manvityagi

Manvityagi commented 3 years ago

@DeepanshiD @vaishali614

RuchiGitHu commented 3 years ago

@DeepanshiD @vaishali614

Kindly review my PR @Manvityagi

vaishali614 commented 3 years ago

@RuchiGitHu That doesn't really look good to me. Footers aren't usually this much crowded. I think the purpose of navigating to homepage is served by the logo in header. If you still feel the need, then we'll probably need to change the design of the footer. @DeepanshiD can probably help with that. CC: @Manvityagi

RuchiGitHu commented 3 years ago

@RuchiGitHu That doesn't really look good to me. Footers aren't usually this much crowded. I think the purpose of navigating to homepage is served by the logo in header. If you still feel the need, then we'll probably need to change the design of the footer. @DeepanshiD can probably help with that. CC: @Manvityagi

First of all thanks for your important review. Secondly, I think less people are aware or would have idea that after clicking in logo they can go back to home page. I will change my way of solving this issue and this time it will not too crowded in footer in fact I were thinking to resolve this other approach (I can add only Home button in navbar, this will not effect footer and the home button in navbar will let user go to home). Your suggestions are welcome as always. Looking forward for your reply @Manvityagi @DeepanshiD @vaishali614

vaishali614 commented 3 years ago

@RuchiGitHu That doesn't really look good to me. Footers aren't usually this much crowded. I think the purpose of navigating to homepage is served by the logo in header. If you still feel the need, then we'll probably need to change the design of the footer. @DeepanshiD can probably help with that. CC: @Manvityagi

First of all thanks for your important review. Secondly, I think less people are aware or would have idea that after clicking in logo they can go back to home page. I will change my way of solving this issue and this time it will not too crowded in footer in fact I were thinking to resolve this other approach (I can add only Home button in navbar, this will not effect footer and the home button in navbar will let user go to home). Your suggestions are welcome as always. Looking forward for your reply @Manvityagi @DeepanshiD @vaishali614

I agree with you that people are less aware about logo on navbar can take them to homepage. However, we do have a Products section in footer where Opportunity Calendar takes us to the homepage. I'm not really sure if adding a Home button or simply a link in navbar would look good. I think @DeepanshiD can help us better with this decision. CC: @Manvityagi

DeepanshiD commented 3 years ago

@RuchiGitHu We have a sticky header and we are adding same contents of header in footer, which isn't a nice decision anyway. I don't think there's a need of footer navigation CC: @vaishali614 @Manvityagi

Manvityagi commented 3 years ago

@RuchiGitHu We have a sticky header and we are adding same contents of header in footer, which isn't a nice decision anyway. I don't think there's a need of footer navigation CC: @vaishali614 @Manvityagi

Hmm, That's apt @DeepanshiD. Okay, let's keep it this way, Sorry @RuchiGitHu will have to close this one. Thanks for the efforts that you have made.