Girl-Code-It / Opportunity-Calendar-Frontend

Opportunity Calendar is the one-stop place to refer important opportunites available in tech-space like newly posted jobs, internships, hackathons, tech-conferences, scholarhsips etc.

https://cutt.ly/opportunity-calendar

MIT License

49 stars 88 forks source link

Social Icons added #250

Closed ShrutiOmer closed 3 years ago

ShrutiOmer commented 3 years ago

Description

I have added social icons to left of website Fixed #242

Type of change

Please check options that are relevant to your PR.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] This change requires a documentation update

Checklist:

[x] I have pulled the latest changes in the repository
[x] I have squashed my commits
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

ShrutiOmer commented 3 years ago

I have made the changes. @Manvityagi please review it. Untitled

Manvityagi commented 3 years ago

Doesn't this look a bit off on this screen? CC: @vaishali614

Let's have the social media icons only on Home Page?

Manvityagi commented 3 years ago

Doesn't this look a bit off on this screen? CC: @vaishali614

Let's have the social media icons only on Home Page?

@ShrutiOmer

vaishali614 commented 3 years ago

Doesn't this look a bit off on this screen? CC: @vaishali614

Let's have the social media icons only on Home Page?

I agree. Let's have it on the homepage only.

vaishali614 commented 3 years ago

I think there's too much space here, can we reduce it a bit?

Capture

ShrutiOmer commented 3 years ago

@Manvityagi @vaishali614 I have added social icons in the home page, but the space is changing with zoom level. see this

and with different zoom

It is behaving same as in original site.

If I will change left margin from auto to something then it will not come in centre.

vaishali614 commented 3 years ago

@ShrutiOmer No problem. Looks good this way. Please take the latest pull from upstream and update your PR so that I can merge this PR.

ShrutiOmer commented 3 years ago

@vaishali614 I have pull the upstream.

ShrutiOmer commented 3 years ago

@vaishali614 @rakshaa2000 @Manvityagi please add the labels, without labels point will not update in leaderboard.