Girl-Code-It / Opportunity-Calendar-Frontend

Opportunity Calendar is the one-stop place to refer important opportunites available in tech-space like newly posted jobs, internships, hackathons, tech-conferences, scholarhsips etc.

https://cutt.ly/opportunity-calendar

MIT License

49 stars 88 forks source link

Updated files for Post Opportunity #259

Closed Sukriti-sood closed 3 years ago

Sukriti-sood commented 3 years ago

Description

Made Chnages to Form UI of Post Opportunity according to the Design
Added Find Opportunity Button in Navbar which will redirect to View Opportunity page of respective opportunity
UI is Responsive.

Fixed #165

Type of change

Please check options that are relevant to your PR.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] This change requires a documentation update

Checklist:

[x] I have pulled the latest changes in the repository
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings

Opportunity Cale (1) Opportunity Cale (2)

Sukriti-sood commented 3 years ago

[x] Female specific text isn't in the right font-style, font-size and font-weight.
[x] Female specific toggle should be next to the description.
[x] Labels shouldn't be italic.
[x] Heading should be properly aligned with the form fields.
[x] There shouldn't be any space between the form background and footer.

@vaishali614 I didn't get about which Post Opportunity Button you are mentioning

vaishali614 commented 3 years ago

[x] Female specific text isn't in the right font-style, font-size and font-weight.

[x] Female specific toggle should be next to the description.

[x] Labels shouldn't be italic.

[x] Heading should be properly aligned with the form fields.

[x] There shouldn't be any space between the form background and footer.

@vaishali614 I didn't get about which Post Opportunity Button you are mentioning

It wasn't visible earlier, but it's there now. Just align it along the form fields. And keep the border radius similar to the one in navbar.
Labels shouldn't be bold. Keep the font-weight same as in the design.
Female specific toggle button should be aligned with the bottom of description, not the top of it.

Rest everything seems fine.

Also, the deploy-preview seems distorted. Maybe that's because of the merge conflicts, please resolve it and test the deploy-preview completely before updating your PR.

Sukriti-sood commented 3 years ago

@vaishali614 I didn't change the position of Toggle because at bottom , it doesn't' looks good Opportunity Cale (3) Opportunity Cale (4)

vaishali614 commented 3 years ago

@Sukriti-sood Yeah you're right. Let the toggle button be next to website field then.

Also, a recent PR has been merged which combines all these forms into one. You'll have to get rid of merge conflicts now. Please do that carefully. Make sure you don't destroy your changes.

Sukriti-sood commented 3 years ago

@Sukriti-sood Yeah you're right. Let the toggle button be next to website field then.

Also, a recent PR has been merged which combines all these forms into one. You'll have to get rid of merge conflicts now. Please do that carefully. Make sure you don't destroy your changes.

@vaishali614 Done , If you also think Please make this PR level3 ,