Closed ayush221b closed 6 years ago
Two suggestions:
Add screenshots to a screenshots/
folder so that we can better review your changes and correlate with code.
Move all your code and screenshots to poc/feature-donate/ayush221b
Suggestions incorporated. For a full and identical experience, please visit: https://gssoc-eff9f.firebaseapp.com/
LGTM
As a future extension to your work, consider following points:
Abstracting out the URLs of donations account to a config file. So, that the change is easy to locate and perform. Currently, it needs some effort to locate the URLs for donations account.
Making all the donations in one <div> all code goes in here</div>
. Then, it would become like a module which can be integrated easily into any website.
What is this PR for?
This pull request adds a demo donate page for GirlScript India, following the guidelines provided in issue #6 .
Is this complete?
Yes. The page is complete, with one exception. The Paypal donate button will be updated once the Paypal business setup verification is complete, apart from it, everything is functional.
Comments
Please let me know of any feedback.