search

GirlScriptSummerOfCode / GirlScript_India

GirlScript is the fastest growing tech-community in India. It is a non-profit project brought to you by GirlScript Foundation to help beginners in technology. Be a part, spread knowledge & happiness..
MIT License
12 stars 14 forks source link

Demo Donate Page Added ( Issue #6) #9

Closed ayush221b closed 6 years ago

ayush221b commented 6 years ago

What is this PR for?

This pull request adds a demo donate page for GirlScript India, following the guidelines provided in issue #6 .

Is this complete?

Yes. The page is complete, with one exception. The Paypal donate button will be updated once the Paypal business setup verification is complete, apart from it, everything is functional.

Comments

Please let me know of any feedback.

vishwarajanand commented 6 years ago
  1. The design looks good and neat.
  2. The goal of issue #6 is to just make donation buttons, for the other aspects you can work to improve later on also.
  3. Consider focusing on the main goal of a working donations buttons first.
vishwarajanand commented 6 years ago

Two suggestions:

  1. Add screenshots to a screenshots/ folder so that we can better review your changes and correlate with code.

  2. Move all your code and screenshots to poc/feature-donate/ayush221b

ayush221b commented 6 years ago

Suggestions incorporated. For a full and identical experience, please visit: https://gssoc-eff9f.firebaseapp.com/

vishwarajanand commented 6 years ago

LGTM

As a future extension to your work, consider following points:

  1. Abstracting out the URLs of donations account to a config file. So, that the change is easy to locate and perform. Currently, it needs some effort to locate the URLs for donations account.

  2. Making all the donations in one <div> all code goes in here</div>. Then, it would become like a module which can be integrated easily into any website.