GirlScriptSummerOfCode / Kranti

MIT License
9 stars 16 forks source link

Design and Implement the Contact tab #19

Open lalitmee opened 6 years ago

lalitmee commented 6 years ago

For requirements, refer to https://drive.google.com/drive/folders/0BwpCIeAR0xFcTVlXc1FvQXZvcHM?usp=sharing

Try to come up with a simple and clean design of the Contact tab. :+1: For any help regarding any query contact in the channel Kranti.

devesh-verma commented 6 years ago

I would like to work on this. Plz assign it to me.

lalitmee commented 6 years ago

@devshiva619, did you complete the last assigned issue?

devesh-verma commented 6 years ago

@lalitmee only minor change. I will produce the PR my tonight for that and for this by tomorrow or day after.

ayush221b commented 6 years ago

Can you please give me this issue?

lalitmee commented 6 years ago

@devshiva619, until and unless your last PR related to the assigned issue is not merged, you can't be assigned to another issue.

AvaniVerma commented 6 years ago

@ayush221b I've already assigned an issue to you. So you can't work on this one.

shreyateeza commented 6 years ago

@AvaniVerma I would like to work on this issue.

adi44 commented 6 years ago

I will do it

saberprashant commented 6 years ago

I would like to work on this one, so can anyone assign this to me? @AvaniVerma @lalitmee @troublemagnet

lalitmee commented 6 years ago

@shreyateeza, @adi44, and @saberprashant do you guys have any other issue pending?

shreyateeza commented 6 years ago

@lalitmee Yes I am working on issue #17. But would like to work on this as well if possible.

saberprashant commented 6 years ago

@lalitmee No, I have no issue pending, the last issue on which I was working was "Designing a logo" and I submitted that already.

lalitmee commented 6 years ago

@shreyateeza, if this is the case, I would suggest you finish that first. If you want help with your previous issue, contact us on the slack channel. :+1: @saberprashant, I think you can work on this. I hope you know React.js. Because till now I haven't seen anyone using the correct way of React.js Development in our project. :worried:

saberprashant commented 6 years ago

@lalitmee , Thanks for assigning me this one, I will try my best to implement it with react standards and first I will provide a basic design of what I am going to implement in this tab, so you will also get the idea how I am going to do it. So tomorrow around 12pm, I will mention the design here. :)

adi44 commented 6 years ago

I dont have any issues pending pls assign some issue

saberprashant commented 6 years ago

@lalitmee @troublemagnet @AvaniVerma,
Hi there,
Well, I made a basic design for the Contact tab as per your requirements(drive link). I tried to keep it simple and to provide everything in a single page view. Also, this design is just a pointer of what I am thinking to make, so your suggestions are most welcome :)
--View the design here--

AvaniVerma commented 6 years ago

@saberprashant Design looks good to me but the final decision will depend on the implementation. So go ahead and code it.

saberprashant commented 6 years ago

@AvaniVerma , Okay, I will start implementing this and will submit a PR.

lalitmee commented 6 years ago

@saberprashant, yeah design is good. try to make it as much as clean and good looking. :+1:

saberprashant commented 6 years ago

Hi there @lalitmee, I see that no one worked on the back-end for this project yet, so, can I make the database for the contact tab on m-lab? So, that I can connect the part with the node.js for the updates form.

lalitmee commented 6 years ago

@saberprashant, I don't think that there is need of database.. only the thing we need to do is to set up some email contact and mobile notification thing so that some person from the organization can know that someone wants to connect with them

saberprashant commented 6 years ago

Then I think, we can use firebase for that.

On Fri, 27 Jul 2018, 9:43 pm Lalit Kumar, notifications@github.com wrote:

@saberprashant https://github.com/saberprashant, I don't think that there is need of database.. only the thing we need to do is to set up some email contact and mobile notification thing so that some person from the organization can know that someone wants to connect with them

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GirlScriptSummerOfCode/Kranti/issues/19#issuecomment-408466837, or mute the thread https://github.com/notifications/unsubscribe-auth/ATv06BZEunEJ2ZWHPBhpjWxsCFT8QDuVks5uKzw9gaJpZM4VQJ9A .

lalitmee commented 6 years ago

okk, you can do whatever you want to do.. and create a PR

saberprashant commented 6 years ago

Okay then, I will have to change the form accordingly. Will submit a PR by the end of this Sunday :)

On Fri, 27 Jul 2018, 10:18 pm Lalit Kumar, notifications@github.com wrote:

okk, you can do whatever you want to do.. and create a PR

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GirlScriptSummerOfCode/Kranti/issues/19#issuecomment-408475927, or mute the thread https://github.com/notifications/unsubscribe-auth/ATv06BIT_PcbEX-GxqceJCsUBKVTran-ks5uK0RUgaJpZM4VQJ9A .

saberprashant commented 6 years ago

Hi @lalitmee , can you please merge the old pull requests of other contributors related to tabs and other, so that I can connect my code with that, as currently, I have nothing to pull from the code base. Plus, I need to add the firebase, so it would be better if you will create a firebase account in name of Kranti(email).
Thanks!

troublemagnet commented 6 years ago

@saberprashant I closed the PR related to tabs due to inactivity, please feel free to make one yourself.