search

GirlScriptSummerOfCode / MakkalaJagriti

New Web Project for Makkala Jagriti
MIT License
5 stars 9 forks source link

Add pre-commit hook #4 #8

Open adarshlilha opened 6 years ago

adarshlilha commented 6 years ago

Added husky and modified package.json scripts to run linter before git commit

adarshlilha commented 6 years ago

@rahulrana95 should all the words in the commit message be capitalized (Add Precommit Hook) or only the first word of the message(Add precommit hook) ?

rahulrana95 commented 6 years ago

@adarshlilha Make first character of all letters capital

iamchathu commented 6 years ago

@adarshlilha Any update on this PR

adarshlilha commented 6 years ago

sorry for the delay. I tried using husky to run a custom script to verify all words start with a capital letter but couldn't get this working. Will need help from someone to look into this.

rahulrana95 commented 6 years ago

Google about pre-hook and how it works.

iamchathu commented 5 years ago

@adarshlilha Are you planning to work on this issue?

@rahulrana95 Please Provide complete comment with what needs to updated in the PR to merge. Need to close this soon.