Challenge 1 Feedback

[meredithcat]

Challenge 1 Feedback: 4/20 Feedback based on Challenge 1 Rubric

For future challenges please refer to starter code.

• Solution: 1 (x2 = 2)

  • Does not generate a graph from the input file (only a list of edges)
  • Treats all graphs as directed graphs
  • Does not handle unweighted graphs

• Documentation: 1

  • Good documentation, but does not accurately describe code

• Organization: 1

  • Graph and Digraph classes are not actually being used for storing vertices and edges
  • Graph / Digraph should have an add_edge method or similar which handles that logic, rather than storing edges in a separate data structure

• Testing: 0

  • Add unit tests

[GirugaCode]

My original grade was Challenge 2 Feedback: 4/20

[meredithcat]

Challenge 1 Feedback (Resubmit): 8/20

• Solution: 1 (x2 = 2)

  • Code breaks for Digraphs
  • Code breaks for unweighted edges

• Documentation: 2

  • Most files have docstrings and are well-formatted; however formatting is not consistent across all functions

• Organization: 2

  • read_file is tightly coupled with the Challenge 1 code, as it is returning a graph, list of (string) vertices, and list of (string) edges. Could return just a graph instead.

• Testing: 2

  • No tests for file processing