Gisellameloni / svg-edit

Automatically exported from code.google.com/p/svg-edit
MIT License
0 stars 0 forks source link

Default color as none #1230

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1.When i try to draw objects default color is red

What is the expected output? What do you see instead?
Default color should be none

In what version of SVG-edit does the problem occur? (Latest trunk, 2.7.1,
etc) yes

Please provide any additional information below.

Original issue reported on code.google.com by shobhabk...@gmail.com on 28 Jul 2014 at 11:05

GoogleCodeExporter commented 9 years ago
Fixed.

Original comment by shobhabk...@gmail.com on 28 Jul 2014 at 11:10

GoogleCodeExporter commented 9 years ago
I guess you mean, Invalid, so marking as such.

Original comment by bret...@gmail.com on 29 Jul 2014 at 4:03

GoogleCodeExporter commented 9 years ago
Did the changes in code.And issue got fixed.

Original comment by shobhabk...@gmail.com on 29 Jul 2014 at 4:22

GoogleCodeExporter commented 9 years ago
I seem to remember testing with the color red, but I don't see that I added a 
commit for it anywhere, and testing on trunk does not show red for me. Did you 
find the line of code responsible for making it red? Or was it just remembering 
what color you chose before?

Original comment by bret...@gmail.com on 29 Jul 2014 at 4:56

GoogleCodeExporter commented 9 years ago
It is in the svg-editor.js.I just made defaultConfig changing InitFill with 
opacity to 0.Make the color none. 

Original comment by shobhabk...@gmail.com on 30 Jul 2014 at 5:48

GoogleCodeExporter commented 9 years ago
I see. Glad you found the relevant config to alter the defaults. I'd like to 
get more input from others here about whether to change the default. While 
there is a visible border to help keep the object visible, I think it may still 
be handy to have a visible default fill color so that people are aware that 
fill color is available. But I'm not really attached to this opinion...

Original comment by bret...@gmail.com on 30 Jul 2014 at 6:03