search

GiselleSerate / myaliases

Useful shell aliases and functions.
6 stars 1 forks source link

cds tab complete shell conditional agh #68

Closed aryarm closed 6 years ago

aryarm commented 6 years ago

In order to prevent .bash_cds from attempting to register cds tab completions in a shell that is unsupported, I check $BASH_VERSION to see whether the current shell is bash (and not zsh, for example, which uses a different completion system).

Unfortunately, this has disabled cds tab completion on some bash systems. Fix the conditional so that it can better detect which shell you're using. Maybe also look at the setup script because we had to do this back then, right?

aryarm commented 6 years ago

this way seems pretty portable

aryarm commented 5 years ago

Looking back on this issue, I'm not really sure why I said that the old method would disable tab completion on some bash systems. In fact, the old method was actually more portable. For example, the old method works on BusyBox while the new method doesn't. In any case, I revert to the old method in 38c86ea.