GiselleTan / pe

0 stars 0 forks source link

Contacts with the same name but different information should be allowed #10

Open GiselleTan opened 2 months ago

GiselleTan commented 2 months ago

There are cases in the real world where people have the same name.

Steps to reproduce:

  1. Add a person as follows: /add-person ; name : Janna ; phone : 98765435 ; address : Poochie Street 24 ; email : ihelppooches@gmail.com

  2. Attempt to add a person with the same name but different details as follows: /add-person ; name : Janna ; phone : 98765432 ; address : PoochieStreet 25 ; email : iihelppooches@gmail.com

Expected: Allow contacts with same name but different information to be added.

Actual: Does not allow contacts with same name but different information to be added.

Screenshot: Screenshot 2024-04-19 at 4.48.55 PM.png

nus-se-bot commented 2 months ago

Team's Response

Since many of our functions relies on the name, such as delete, it does not make sense to allow for duplicate names. However, users can append numerical numberings to their contact, should they have the same name, e.g. janna tan 1 , janna tan 2, in the rare occasion that multiple contacts have the exact same name, thus, preventing the loss of usability.

Since exact same name only occurs in rare occasions, we believe that this is unlikely to affect normal operations, and will hence be changing the severity to low.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]