GiselleTan / pe

0 stars 0 forks source link

Unclear error message when adding duplicate contacts #2

Open GiselleTan opened 5 months ago

GiselleTan commented 5 months ago

Steps to reproduce:

  1. Add a staff as below /add-staff ; name : Janna ; phone : 98765435 ; address :PoochieStreet 24 ; email : ihelppooches@gmail.com ; salary :$50/hr ; employment : part-time
  2. Add a person as below /add-person ; name : Janna ; phone : 98765435 ; address : Poochie Street 24 ; email : ihelppooches@gmail.com

Expected: Error should specify at least the name of the duplicate contact

Actual: See below in screenshot

Screenshot: Screenshot 2024-04-19 at 4.17.07 PM.png

soc-se-bot commented 5 months ago

Team's Response

The error message explicitly mentions that the contact already exists so it is clear that there is a duplicate person.

In our ug, it also explicitly mentions what kinds of duplicates are not allowed, clearly stating that that duplicate names are not allowed. Thus we believe this behaviour is made very clear to the user.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]