nus-pe-script
commented
5 months ago Team's Response
Both issues find problems with accepting numbers in the name. They believe names should not accept numbers.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Names can include numbers
Feature Flaw (Severity Low) Steps to reproduce
- Input
/add-person ; name : 12345678 ; phone : 98765435 ; address : Poochie Street 24 ; email : ihelppooches@gmail.comExpected Error message to be shown that name is only a number
Actual No error message shown and the user is added to the addressbook
[original: nus-cs2103-AY2324S2/pe-interim#1088] [original labels: severity.Low type.FeatureFlaw]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
This was an intentional feature since it is possible to have a name with numbers, for example, Elon Musk's child XÆ 12.
Additionally, it is not a feature flaw since it does not value add to disallow such naming formats. However, our current implementation does value add as it enhances the flexibility and usability of our application for the user.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
## :question: Issue response Team chose [`response.Rejected`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
Steps to reproduce: Add a person as follows: /add-person ; name : J1 ; phone : 98765435 ; address : Poochie Street 24 ; email : ihelppooches@gmail.com
Expected: Contact's names should not have numerical values
Actual: Contacts names can contain numerical values
Screenshot: