GiselleTan / pe

0 stars 0 forks source link

Delete command requires users to type in the name but names could be too long #9

Open GiselleTan opened 2 months ago

GiselleTan commented 2 months ago

Users need to type in the name of the contact they wish to delete, however, there are cases where the name of the person may be too long. This may result in users taking longer to delete a contact.

nus-se-bot commented 2 months ago

Team's Response

While typing a long name may be a hassle, it is necessary to locate contacts with long names as a fail safe mechanism. I believe your suggestion is to allow deletion of partial names but this may lead to accidental deletion of names.

Furthermore, aws actually uses the same approach where users must specify the full name of a person to delete the contact.

image.png

This is a "safe delete" implementation to make sure user delete the right contact, this is the intended behaviour for user to delete a contact more carefully.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: My suggestion would be to delete by index instead as it would be much faster than typing out the full name. If you have a contact with a long name, you are unable to copy and paste the contact name from the application itself. Hence, users need to type the name out and may misspell it. Furthermore, if the name is very long such that it gets cut off in the application, what should users do then, if they do not remember the full name and the spelling?