Giskard-AI / giskard

🐢 Open-Source Evaluation & Testing for ML models & LLMs
https://docs.giskard.ai
Apache License 2.0
3.92k stars 250 forks source link

Update evaluate.py #1930

Closed natedem30 closed 4 weeks ago

natedem30 commented 4 months ago

Description

Related Issue

Type of Change

Checklist

sentry-io[bot] commented 4 months ago

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: giskard/rag/evaluate.py

Function Unhandled Issue
evaluate LLMGenerationError: Error while evaluating the agent main in <mod...
Event Count: 4
evaluate NameError: name 'domain' is not defined src.modul...
Event Count: 2
evaluate NameError: name 'doc_chat' is not defined _main...
Event Count: 1
evaluate NameError: name 'domain' is not defined main ...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

kevinmessiaen commented 4 months ago

Hello @natedem30

Thanks for the contribution. It look like the goal if the PR is to refactor the code. Would it be possible from you to update the PR tittle and description? Thanks!