Giskard-AI / giskard

🐢 Open-Source Evaluation & Testing for ML & LLM systems
https://docs.giskard.ai
Apache License 2.0
4.07k stars 267 forks source link

Fixed bug that prevented to create an empty df #1966

Closed kevinmessiaen closed 4 months ago

kevinmessiaen commented 4 months ago

Description

Fixed bug that prevented to create an empty df

Following code now works:

import pandas as pd
import giskard

giskard.Dataset(df=pd.DataFrame([], columns=["test"]))

Related Issue

Type of Change

Checklist

sentry-io[bot] commented 4 months ago

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: giskard/core/dataset_validation.py

Function Unhandled Issue
_check_hashability IndexError: index 0 is out of bounds for axis 0 with size 0 main ...
Event Count: 7

Did you find this useful? React with a 👍 or 👎

henchaves commented 4 months ago

It doesn't work here :(

image
kevinmessiaen commented 4 months ago

@henchaves I fixed the issue, I was using the wrong params

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud