Added MistralEmbedding - Githubissues

Giskard-AI / giskard

🐢 Open-Source Evaluation & Testing for ML & LLM systems

https://docs.giskard.ai

Apache License 2.0

4.07k stars 267 forks source link

Added MistralEmbedding #1985

Closed kevinmessiaen closed 2 weeks ago

kevinmessiaen commented 4 months ago

Description

Added MistralEmbedding to allow running the rag toolkit

TODO:

[x] 🚀 Add MistralEmbedding class
[ ] 📚 Update doc
[ ] 🧪 Add tests

Related Issue

Type of Change

[ ] 📚 Examples / docs / tutorials / dependencies update
[ ] 🔧 Bug fix (non-breaking change which fixes an issue)
[ ] 🥂 Improvement (non-breaking change which improves an existing feature)
[x] 🚀 New feature (non-breaking change which adds functionality)
[ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🔐 Security fix

sonarcloud[bot] commented 4 months ago

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

sonarcloud[bot] commented 2 months ago

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

alexcombessie commented 1 month ago

Hey @kevinmessiaen - Is this PR ready for review?

alexcombessie commented 2 weeks ago

Hey @kevinmessiaen - any news on this PR?

kevinmessiaen commented 2 weeks ago

Hey @kevinmessiaen - any news on this PR?

We will be working on implementing litellm instead which will allow to work with most provider without custom code

alexcombessie commented 2 weeks ago

Clear, thanks!