Giskard-AI / giskard

🐢 Open-Source Evaluation & Testing for ML & LLM systems

https://docs.giskard.ai

Apache License 2.0

4.07k stars 267 forks source link

Fix incorrect temperature usage in `_LLMBasedQuestionGenerator` #2007

Closed ghost closed 2 months ago

ghost commented 2 months ago

Description

This PR fixes incorrect temperature usage in the _llm_complete method of the _LLMBasedQuestionGenerator class as described in the related issue. It replaces the hardcoded temperature value of 0.5 with self._llm_temperature.

Related Issue

1998

Type of Change

[ ] 📚 Examples / docs / tutorials / dependencies update
[x] 🔧 Bug fix (non-breaking change which fixes an issue)
[ ] 🥂 Improvement (non-breaking change which improves an existing feature)
[ ] 🚀 New feature (non-breaking change which adds functionality)
[ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🔐 Security fix

Checklist

[x] I've read the CODE_OF_CONDUCT.md document.
[x] I've read the CONTRIBUTING.md guide.
[ ] I've written tests for all new methods and classes that I created.
[ ] I've written the docstring in Google format for all the methods and classes that I used.
[ ] I've updated the pdm.lock running pdm update-lock (only applicable when pyproject.toml has been modified)

kevinmessiaen commented 2 months ago

Thanks @asselindebeauville for your contribution! 🎉