docs: update hotel_text_regression.ipynb - Githubissues

Giskard-AI / giskard

🐢 Open-Source Evaluation & Testing for ML models & LLMs

https://docs.giskard.ai

Apache License 2.0

3.92k stars 250 forks source link

docs: update hotel_text_regression.ipynb #2024

Closed eltociear closed 1 day ago

eltociear commented 1 week ago

Description

minor fix

Related Issue

Type of Change

[ ] 📚 Examples / docs / tutorials / dependencies update
[ ] 🔧 Bug fix (non-breaking change which fixes an issue)
[ ] 🥂 Improvement (non-breaking change which improves an existing feature)
[ ] 🚀 New feature (non-breaking change which adds functionality)
[ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🔐 Security fix

Checklist

[ ] I've read the CODE_OF_CONDUCT.md document.
[ ] I've read the CONTRIBUTING.md guide.
[ ] I've written tests for all new methods and classes that I created.
[ ] I've written the docstring in Google format for all the methods and classes that I used.
[ ] I've updated the pdm.lock running pdm update-lock (only applicable when pyproject.toml has been modified)

henchaves commented 1 day ago

Hello @eltociear, thanks for opening this PR.

Actually, you are updating the HTML generated by the scanner, which only shows some examples from the original dataset. This dataset contains user reviews about hotels, so it's normal to have some typos in it since it was written by humans. Therefore, there's no need to correct these typos; it's part of the model's learning process to understand them as well.