Closed alexjharrison closed 1 year ago
Just realized I started with a very old branch. Will rework this.
sorry to hear that @alexjharrison is this my fault? I am new at maintain a repo too, so may I had to inform you?
No this was on me. I made the fix on my original fork and didn't update to the latest master which had many more changes.
My fix mostly works but I'm working on edge cases for different screen sizes. I should have another PR tomorrow.
Description
slide-fade
was added to define how it should enter and exitThe main issue is that I hardcoded the starting height of the div during the transition to 44px. https://github.com/alexjharrison/vue-cookie-consent-banner/blob/20-cookie-options-transition/src/components/CookieModal.vue#L276
Setting to
height: 100%
broke the transition and reading the height with JS reports a height of 0px when in a closed state. Not sure how to handle this when the slot is overwritten.Issue Ticket Number
Fixes #20
Type of change
Checklist: