Gismo1337 / vue-cookie-consent-banner

Vue Cookie Consent Banner Component without dependecies. Feel free to contribute.
https://github.com/Gismo1337/vue-cookie-consent-banner
MIT License
5 stars 18 forks source link

feat: Add fade transition for cookie options #56

Closed alexjharrison closed 1 year ago

alexjharrison commented 1 year ago

Description

The main issue is that I hardcoded the starting height of the div during the transition to 44px. https://github.com/alexjharrison/vue-cookie-consent-banner/blob/20-cookie-options-transition/src/components/CookieModal.vue#L276

Setting to height: 100% broke the transition and reading the height with JS reports a height of 0px when in a closed state. Not sure how to handle this when the slot is overwritten.


Issue Ticket Number

Fixes #20


Type of change


Checklist:

alexjharrison commented 1 year ago

Just realized I started with a very old branch. Will rework this.

Gismo1337 commented 1 year ago

sorry to hear that @alexjharrison is this my fault? I am new at maintain a repo too, so may I had to inform you?

alexjharrison commented 1 year ago

No this was on me. I made the fix on my original fork and didn't update to the latest master which had many more changes.

My fix mostly works but I'm working on edge cases for different screen sizes. I should have another PR tomorrow.