GispoCoding / eis_qgis_plugin

A QGIS plugin for mineral prospectivity mapping
https://eis-he.eu/
GNU General Public License v2.0
8 stars 1 forks source link

Add filter/smoothing algorithms to plugin #94

Closed lehtonenp closed 3 months ago

lehtonenp commented 4 months ago

This pull request adds the following filtering functions to the plugin in a new group called Filtering

All of the above filtering functions were ran successfully in QGIS.

Note I put plausible values to minValue in the filter functions. If those need corrections, let me know.

msmiyels commented 3 months ago

@nmaarnio @lehtonenp

According to the notes made during coding: NLooks: int: >= 1 Damping Factor: Number: >= 0.0 Noise Mean: Number: any Noise Variance: Number: any

truncate and sigma are at least for the gaussian dependent from each other. But theoretically, truncate can be 0. If the resulting size of the window is too small (which it is every time if truncate equals zero), it throws an error anyway. sigma must be > 0.

Theoretically, noise_mean and noise_variance can have any value, but I would think restricting it to >= 0 would make sense, since I cannot really imagine what a negative noise should be or rather look like.

❓ Should we update the toolkit functions as well? E.g. noise min?

nmaarnio commented 3 months ago

Thanks! Yeah, I think it would be a good idea to update the minimum values / their documentation in the toolkit, but no big hurry with that.

lehtonenp commented 3 months ago

@nmaarnio, I have now set the minValue params to 0.