search

GispoCoding / eis_toolkit

Python library for mineral prospectivity mapping
https://eis-he.eu/
European Union Public License 1.2
26 stars 8 forks source link

Add smoothing/filter CLI functions #293

Closed nmaarnio closed 8 months ago

nmaarnio commented 10 months ago

@msmiyels , I will implement the CLI functions for these tools soon, and I thought it'd be a good idea to think a little bit how these tools will show up in QGIS. There are quite many different tools that fall under this filter category. In QGIS processing algorithms, it is not possible to create groups within groups, and therefore all these tools would show up directly under raster processing.

So I guess what I am after is that do you think it's ok to directly transfer all the public functions of these filter functions to the processing algorithms, or do we want to try to "merge" some tools into one and dividing behaviour with parameters, thus reducing the number of entries in the processing algorithm menu? We could also create a "level 1" group just for these filters, so they wouldn't fall under raster processing in QGIS, this might be a good solution too, if we want to make it cleaner and easier for users to find different tools.

msmiyels commented 10 months ago

@nmaarnio, good question 🙄. Let me think about it 🤯 and we can catch it up in the weekly on Wednesday?

Question: This would affect the derviatives as well, right?

nmaarnio commented 10 months ago

Yes, I think we could think about the derivates too. And yes, we can discuss these on Wednesday if you think it won't take too long

msmiyels commented 10 months ago

Huhu,

okay, than I'll vote 🗳 for Wednesday 😉 We should be able to keep it in time ^^

msorvoja commented 10 months ago

I made cli functions for these filter functions. When testing with the same raster data as the tests for these functions (which pass), I get SystemError: <built-in function len> returned a result with an exception set with Lee enhanced, frost and kuan filters.