GispoCoding / master-training-data

Repo for Gispo training materials.
1 stars 0 forks source link

GP001: fix outdated filenames in exercises #47

Closed eemilhaa closed 1 month ago

eemilhaa commented 1 month ago

Fixes #45

In addition to just replacing file extension, I also updated the filenames according to the new course directory.

Some things to consider before merging:

github-actions[bot] commented 1 month ago

Preview changes here.

jeeemil commented 1 month ago

Elisa is in charge of this course, but since she is away, and I've been teaching this course in the spring at least once I guess I could check the Shapefile-text. Since the data is changed the only logical thing to do is to also change the text as you did. I think we could go forward with this and when Elisa returns, or if the course is up for more in-depth updates, then it could be discussed if we should have an exercise where we go through shapefiles. Then we could just grab the nice tables and stuff from this course. In any case I feel the most logical data to add in the beginning would be a geopackage so a shapefile-add could then be a completely separate topic.

I updated the course directory, so point 2 and 3 are done.

github-actions[bot] commented 1 month ago

Preview changes here.

jeeemil commented 1 month ago

@eemilhaa I updated a few images where the old files where present. If the changes are okay with you, this PR is ready for merge.

eemilhaa commented 1 month ago

@jeeemil Looks good to me, good catch on the screenshots!