Closed Joonalai closed 9 months ago
Attention: 5 lines
in your changes are missing coverage. Please review.
Comparison is base (
1895072
) 56.44% compared to head (5af0250
) 56.94%.
Files | Patch % | Lines |
---|---|---|
src/pytest_qgis/utils.py | 33.33% | 4 Missing :warning: |
src/pytest_qgis/qgis_bot.py | 93.75% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@LKajan, could you merge this?
QgisBot.create_feature_with_attribute_dialog
ignored possible errors and warnings in the form. This caused lot of confusion why constraint error is not caught in test.This PR:
raise_from_warnings
andraise_from_errors
parameterscreate_feature_with_attribute_dialog
visually with the optionalshow_dialog_timeout_milliseconds
parameterI chose to leave the default values of
ignore_warnings
andignore_errors
toFalse
since it is important that the writer of the test conciders whether to ignore warnings and errors or to fix the underlying problem in some other way.New release with incremented minor version should be released when this is included. I recommend fixing #47 before the release as well.