GispoCoding / pytest-qgis

A pytest plugin for testing QGIS python plugins
GNU General Public License v2.0
29 stars 8 forks source link

Configurable options and visual map #5

Closed Joonalai closed 2 years ago

Joonalai commented 2 years ago

This PR:

LKajan commented 2 years ago

Maybe not related to this PR but when trying to run tests I got an ImportError from pytest that atomicwrites was not found. That is a new pytest dependency that somewhy was not installed in my venv. I created a separate PR to update the dependencies: https://github.com/GispoCoding/pytest-qgis/pull/6.

LKajan commented 2 years ago

Could you wrap the usage of db.gpkg to a fixture that creates a copy of it before passing it to tests. Now when running tests and accessing the geopackage it gets modified and git wants therefore add changes to the index.

Joonalai commented 2 years ago

@LKajan maybe we should leave the pip-tools part of the pre-commit out of CI?

LKajan commented 2 years ago

@LKajan maybe we should leave the pip-tools part of the pre-commit out of CI?

Yes, it looks to be better so. Now generated dependencies are so different on different platforms.