search

GispoCoding / tarmo

Tarmo - Tampere Mobilemap
https://ulkoilutampereenseutu.fi/
MIT License
11 stars 3 forks source link

Seasons in dataset #58

Closed SannaJokela closed 2 years ago

SannaJokela commented 2 years ago

Was it so, that the season field was determined by Gispo?

In this case, the season is summer although the POI is a skating rink. Also in skiing routes the season is summer. Actually I did not find any winter-season features.

image

Also nature paths might not be seasonal, so there should be a possibility to have "all seasons" POIs and routes.

Rikuoja commented 2 years ago

Yeah currently it is set as "kesä" in our import code on row https://github.com/GispoCoding/tarmo/blob/main/backend/lambda_functions/lipas_loader/lipas_loader.py#L180

@pavetsu14 knows better if there is any actual season information in Lipas, I have no idea.

pavetsu14 commented 2 years ago

@SannaJokela @Rikuoja There is no season information in Lipas. This was a field we were supposed to fill in the appropriate value. I will make an issue on the logic we could give the default value for this field.

Rikuoja commented 2 years ago

Made a PR on the relevant issue, so this can probably be closed now.