search

Git-Gopher / go-gopher

0 stars 1 forks source link

Crash when a PR is closed but not merged #130

Closed valerio-terragni closed 2 years ago

valerio-terragni commented 2 years ago

The tool crashes for one of the teams.

Run gh release download -R https://github.com/Git-Gopher/go-gopher-action -p 'go-gopher-github-action'
time="2022-09-14T10:16:02Z" level=info msg="BuildVersion: eaca249-2022-09-14-03:20:41"
time="2022-09-14T10:16:04Z" level=info msg="Scraped remote GitHub repository in 1.784963132s"
time="2022-09-14T10:16:05Z" level=info msg="Loaded local Git repository in 521.764237ms"
time="2022-09-14T10:16:05Z" level=info msg="Unavailable authors: []"
time="2022-09-14T10:16:05Z" level=info msg="Detector \"EmptyCommit\" from config not found"
time="2022-09-14T10:16:05Z" level=info msg="Detector \"Binary\" from config not found"
time="2022-09-14T10:16:05Z" level=warning msg="unable to find merging commits"
time="2022-09-14T10:16:05Z" level=warning msg="current pr number 6"
time="2022-09-14T10:16:05Z" level=fatal msg="Failed to analyze: Failed to analyze workflow: Failed to run weighted detectors: no closed time for pull request\n"
Error: Process completed with exit code 1.

It seems that we need to consider also the case in which a PR is closed but not merged

fishmonger45 commented 2 years ago

thanks; i'll put a fix for this up quickly. this is what happens when i don't review properly.