search

Git-Harshit / Random_Text_Generator-Brython

Random Text Generator with Python and Brython script.
https://git-harshit.github.io/Random_Text_Generator-Brython/
MIT License
3 stars 5 forks source link

Add button styles #10

Closed nikkuv closed 3 years ago

nikkuv commented 3 years ago

I've changed the button styles a bit and also the background color according to that.

Git-Harshit commented 3 years ago

Well, I have just checked your updated visuals. And, thanks for additionally refactoring some parts of HTML Code. It does look good, however, I did not have any issue with its previous style too.

So @nikkuv, I need your suggestion here. I have just tried looking at your updated style of buttons with the old gradient background. Have a look, and let me know which of the two looks better to you. We can proceed with that style accordingly.

Old Background Latest Proposed Style

Alternatively, if we can have a theme toggle that lets us toggle between these two themes (original one and the latest one you've proposed), that is easily settable using CSS with classes and toggling classname of parent enclosing tag using JS with the toggle button, or anything that you're comfortable with for it, it would be great.

Do let me know your views on it!

nikkuv commented 3 years ago

I think the second one is better in terms of UX because the text is more visible in the plain background than the gradient one and the gradient colors on the buttons don't match with the colors on the background with gradients, so.

Git-Harshit commented 3 years ago

I think the second one is better in terms of UX because the text is more visible in the plain background than the gradient one and the gradient colors on the buttons don't match with the colors on the background with gradients, so.

Okay then! I guess I can merge it into main branch for now. Toggling theme option can be looked into later. Thank you for the Pull Request!