search

Git-Harshit / Random_Text_Generator-Brython

Random Text Generator with Python and Brython script.
https://git-harshit.github.io/Random_Text_Generator-Brython/
MIT License
3 stars 5 forks source link

changing color of text #9

Closed deepu14d closed 3 years ago

deepu14d commented 3 years ago

The button "Re-Generate Text" and it's background both were blue and less distinguishable. So, I just have changed the color of "Re-Generate Text" from blue to white. Now, it is white in color with blue background same as "Copy Text" button.

Git-Harshit commented 3 years ago

Thanks @deepu14d for pointing it out, I too had plans to fix it but I missed out on it. It looks better with whitish text, however causes problem with text visualization in the hovered state of the Re-Generate button, as shown: Re-Generate Hovered

Copy Text, however, seems fine even on hovering: Copy Text Hovered

This issue is mainly also because of the white color already set for #btn1 (around line 51) and the white color you've set for buttons in currently used CSS. You can fix it by using separate color for :hover CSS selector for the button or in any other way that suits you.

Git-Harshit commented 3 years ago

I believe this should work now!

Thank you for your pull request! 🙂

Let me know by commenting below if you'll need hacktoberfest-accepted label as well for this PR.

deepu14d commented 3 years ago

Sorry, I didn't noticed that. You have already fixed. Yeah, it would be nice if you can give that label. Thanks.