search

Git-Jiro / homebrew-jiro

This repository contains homebrew formulae authored by me
26 stars 11 forks source link

leveldb deprecated fix #36

Closed iFoggz closed 7 years ago

iFoggz commented 7 years ago

i need u to look at these changes here and modify ur leveldb accordingly to fix a leveldb deprecated problem acey is having trying to compile the test version of the wallet.

https://github.com/Foggyx420/Gridcoin-Research/commit/9e79bd2f90530731866f05a936a7b04177984227

let me know if it works correctly please so i can pr this and get it into the main repo

Git-Jiro commented 7 years ago

OK. I will give it a try.

iFoggz commented 7 years ago

thank u

Git-Jiro commented 7 years ago

Yes, this worked. I had to fix some other unrelated compilation errors on the development branch as well, but then I got a Gridcoin binary.

These other compilation errors could be easily fixed by adding casts to (int). Those errors looked like this:

==== 8< ---- src/rpcrawtransaction.cpp:106:25: error: conversion from 'size_type' (aka 'unsigned long') to 'const json_spirit::Value_impl<json_spirit::Config_map<std::__1::basic_string > >' is ambiguous res["bhLenght"]=msg.length();


src/json/json_spirit_value.h:46:9: note: candidate constructor
        Value_impl( bool               value );
        ^
src/json/json_spirit_value.h:47:9: note: candidate constructor
        Value_impl( int                value );
        ^
src/json/json_spirit_value.h:48:9: note: candidate constructor
        Value_impl( unsigned int       value );
        ^
src/json/json_spirit_value.h:49:9: note: candidate constructor
        Value_impl( int64_t     value );
        ^
src/json/json_spirit_value.h:50:9: note: candidate constructor
        Value_impl( uint64_t    value );
        ^
src/json/json_spirit_value.h:51:9: note: candidate constructor
        Value_impl( double             value );
        ^
==== 8< ----
iFoggz commented 7 years ago

yes ravon mentioned he forgot to fix this for OSX. i'll keep u updated. thats unrelated to leveldb thats json spirit

ghost commented 7 years ago

Thank you.

Regards, William

On Sep 29, 2017, at 5:08 AM, Paul Jensen notifications@github.com wrote:

yes ravon mentioned he forgot to fix this for OSX. i'll keep u updated. thats unrelated to leveldb thats json spirit

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Git-Jiro/homebrew-jiro/issues/36#issuecomment-332949409, or mute the thread https://github.com/notifications/unsubscribe-auth/AMlfw0O2_9yn6dDZTrkeDo-QTVPSZvEYks5sm_ylgaJpZM4PlMVp.

Git-Jiro commented 7 years ago

I added a small patch to the Formula to cope with the json spirit issue. I hope my patch does not break anything. Could anybody check my commit here? https://github.com/Git-Jiro/homebrew-jiro/commit/2f568f142427e20a87d68ad02974848bec0ed277