Closed scribblemaniac closed 3 years ago
Hi! Before I merge this, can you remove the License stanza again? It seems to break the macOS 10.3 compatible build in Travis CI.
Let me look into this. I have 10.13 and the formula installs just fine on it.
Ok interesting. Then most probably the Homebrew version in the Travis CI image is outdated.
Yes Travis almost never seems to update their images. I assumed it wouldn't be a problem because Homebrew usually automatically runs brew update before starting many commands, but Travis also explicitly disabled that: https://travis-ci.org/github/Git-Jiro/homebrew-jiro/builds/742337948#L60. I've added a call to brew update and it's working now. This is probably a good idea to do anyway to make sure the dependencies are all up to date. I also had to separate the dependency installation into a different step since that adds just enough time for travis_wait to time out.
This PR was initially just to fix the warnings produced by
brew audit --strict gridcoin
. As I went through them, I ended up doing multiple other little things here and there. In the end, this PR does the following: