Git21221 / JS-beginner-projects

Here you will get small JS projects for starters.
https://js-beginner-projects.netlify.app/
47 stars 73 forks source link

Fixed #216

Closed parinitapatil closed 1 year ago

parinitapatil commented 1 year ago

I @parinitapatil have updated your HTML file. Issue #151 , which was reported by @Git21221 , has been resolved.

netlify[bot] commented 1 year ago

Deploy Preview for js-beginner-projects ready!

Name Link
Latest commit f57d278cf750bf60a4978c2532d911e9dd2e30d5
Latest deploy log https://app.netlify.com/sites/js-beginner-projects/deploys/651bea1fc62c540008b572cd
Deploy Preview https://deploy-preview-216--js-beginner-projects.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

gitguardian[bot] commented 1 year ago

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/incidents/secrets) | OpenWeatherMap Token | f57d278cf750bf60a4978c2532d911e9dd2e30d5 | Weather App/js/script.js | [View secret](https://github.com/Git21221/JS-beginner-projects/commit/f57d278cf750bf60a4978c2532d911e9dd2e30d5#diff-a2588ae6a3074e3ff482b192cbff4444L1) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | OpenWeatherMap Token | f57d278cf750bf60a4978c2532d911e9dd2e30d5 | Weather App/js/script.js | [View secret](https://github.com/Git21221/JS-beginner-projects/commit/f57d278cf750bf60a4978c2532d911e9dd2e30d5#diff-a2588ae6a3074e3ff482b192cbff4444R13) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/specifics/open_weather_map#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

parinitapatil commented 1 year ago

will this be counted in hacktoberfest

Git21221 commented 1 year ago

@parinitapatil wait for label after that it will be counted 😊. Thanks for your contribution

parinitapatil commented 1 year ago

Thankyou Project maintainer @Git21221