search

Git21221 / form-snippet

A simple form that made on top of MUI components and uses react hook form for validation.
https://www.npmjs.com/package/form-snippet
MIT License
5 stars 14 forks source link

Button Loader #23

Open Git21221 opened 1 month ago

Git21221 commented 1 month ago

if you hit submit and a API call is going to happen then button should have a loader and should be disable

rishabhrawat05 commented 1 month ago

Hi! @Git21221
I would like to work on the issue so can you please explain it a little more

Git21221 commented 1 month ago

@rishabhrawat05 so I am wrapping mui components with react-hook-form so that all validation and styling done in one place and headache will be low for devs. So all components are from MUI (for now), and if you visit MUI image if someone is calling a API while clicking a button then it should be like this, Loader in button untill API call is done

rishabhrawat05 commented 1 month ago

@Git21221 I understand the issue well, so please assign this issue to me

rishabhrawat05 commented 1 month ago

Hey! @Git21221 Here is the update Screenshot (1)

Git21221 commented 1 month ago

@rishabhrawat05 is there any API involved? Can you send me a video?

rishabhrawat05 commented 1 month ago

@Git21221 Here is the video And I have used an example API to show the working of the button https://www.loom.com/share/35f86c2798714fcf8ae40a7676d2487c?sid=f02a8d3b-b38c-4970-8a40-d0a38091d6d9

Git21221 commented 1 month ago

@rishabhrawat05 looks fine, let's make a PR, then we will review everything