search

GitFiend / Support

Public repo for GitFiend questions and issues
117 stars 7 forks source link

Enter to confirm dialogs #35

Open aaaidan opened 5 years ago

aaaidan commented 5 years ago

Simple confirm and prompt dialogs can be dismissed with Esc but Enter key does nothing. I think it would be great if Enter confirmed the dialog.

E.g.

GitFiend commented 5 years ago

Thanks. I've been putting this off, nice to have an entry for it.

Hazarth commented 4 years ago

Just giving GitFiend a try now and noticed this exact issue when discarding line changes. There's actually a bug with it now. (latest version, just downloaded it, Linux version 0.23.1, installed from Debian package)

when I click Discard, a confirmation dialog pops up, however when I hit Enter, yet another confirmation dialog pops up on top of the first one, I can hit enter as many times as I want, and they will stack on top of each other (I also need to dismiss them one by one).

To be honest, when I clicked discard I wasn't even expecting a dialog to open up, I was expecting the line to just disappear. The thing is in my case, I had several changes under each other, and to discard some of them I have to click discard, move the mouse and hit the OK button, then move back and discard another one. It's kinda slow like that so I'd personally like the option to discard with one click or movement.

That being said, I'm really looking forward learning and using GitFiend, first impressions are top notch so far!