GitGuardian / ggshield

Find and fix 400+ types of hardcoded secrets and 70+ types of infrastructure-as-code misconfigurations.
https://gitguardian.com
MIT License
1.62k stars 143 forks source link

More type checks #787

Closed agateau-gg closed 10 months ago

agateau-gg commented 10 months ago

Pyright settings are a bit lax. Tighten them.

This PR enablesreportUnnecessaryTypeIgnoreComment and reportMissingParameterType options. Going to file another PR in the future to enable reportIncompatibleMethodOverride and reportMissingParameterType.

codecov-commenter commented 10 months ago

Codecov Report

Merging #787 (348b8d4) into main (20d0b01) will increase coverage by 0.00%. Report is 2 commits behind head on main. The diff coverage is 94.44%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main     #787   +/-   ##
=======================================
  Coverage   91.68%   91.68%           
=======================================
  Files         154      154           
  Lines        6348     6353    +5     
=======================================
+ Hits         5820     5825    +5     
  Misses        528      528           
Flag Coverage Δ
unittests 91.68% <94.44%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ggshield/cmd/config/config_list.py 100.00% <100.00%> (ø)
ggshield/cmd/hmsl/hmsl_common_options.py 100.00% <ø> (ø)
ggshield/cmd/sca/scan/__init__.py 100.00% <100.00%> (ø)
ggshield/cmd/utils/common_decorators.py 100.00% <100.00%> (ø)
ggshield/core/config/user_config.py 98.91% <100.00%> (ø)
ggshield/core/filter.py 98.64% <ø> (ø)
ggshield/verticals/auth/oauth.py 85.52% <100.00%> (ø)
...gshield/verticals/secret/secret_scan_collection.py 96.59% <100.00%> (ø)
ggshield/utils/click/natural_order_group.py 80.00% <66.66%> (+5.00%) :arrow_up: