search

GitGuardian / ggshield

Find and fix 400+ types of hardcoded secrets and 70+ types of infrastructure-as-code misconfigurations.
https://gitguardian.com
MIT License
1.62k stars 143 forks source link

chore(sca): show error in case of HTTP 501 #789

Closed tchaumeny closed 10 months ago

tchaumeny commented 10 months ago

See https://linear.app/gitguardian/issue/SCA-1147/deactivate-correctly-in-on-prem

Note that the other API calls already display the associate error message.

codecov-commenter commented 10 months ago

Codecov Report

Merging #789 (ed5b8cb) into main (72f49d9) will decrease coverage by 0.05%. The diff coverage is 0.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #789      +/-   ##
==========================================
- Coverage   91.72%   91.68%   -0.05%     
==========================================
  Files         154      154              
  Lines        6420     6422       +2     
==========================================
- Hits         5889     5888       -1     
- Misses        531      534       +3
Flag Coverage Δ
unittests 91.68% <0.00%> (-0.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ggshield/verticals/sca/file_selection.py 86.48% <0.00%> (-4.95%) :arrow_down:

... and 1 file with indirect coverage changes