Closed irgeek closed 9 months ago
Attention: 6 lines
in your changes are missing coverage. Please review.
Comparison is base (
7da1d68
) 91.89% compared to head (a655394
) 91.91%. Report is 20 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@agateau-gg I've relocated my first implementation into a hooks module. Before I go scribbling in other files to add the check, can you just confirm this looks OK?
As you pointed out, the lint check fails because the PR comes from a fork of the repository. Therefore I am merging it. Will look into that lint bug later.
Hello Aurelien, can you confirm that this will be included in next week's release ?
Thanks in advance
Hello Aurelien, can you confirm that this will be included in next week's release ?
Thanks in advance
Yes, it will be there.
When
ggshield
is configured via the pre-commit framework the user has the option to skip specific scans by setting theSKIP
environment variable. Whenggshield
is configured directly as agit
pre-commit hook, though, the user only has the option to disable all pre-commit hooks via the--no-verify
command-line option. Here we're "borrowing" the pre-commit framework's option so ggshield can be skipped the same way regardless of how it's configured.