GitGuardian / ggshield

Find and fix 400+ types of hardcoded secrets and 70+ types of infrastructure-as-code misconfigurations.
https://gitguardian.com
MIT License
1.62k stars 143 forks source link

Implement auto-ignore #800

Closed Paul-GitGuardian closed 9 months ago

Paul-GitGuardian commented 9 months ago

The API now returns the status of each IaC incident on the GitGuardian app. We should use it to display only incidents that were not ignored on the app.

This applies to all IaC scan commands (all, diff, ci...) in all formats (text, JSON).

Depends on https://github.com/GitGuardian/py-gitguardian/pull/80

Commit 1 bumps the py-gitguardian version Commits 2 and 3 contain some refactoring Commit 4 is the main feature, described above Commit 5 is a warning message in verbose mode when the source is not found by the API

codecov-commenter commented 9 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e787423) 91.92% compared to head (e634d4f) 92.10%. Report is 4 commits behind head on main.

Files Patch % Lines
...rticals/iac/collection/iac_diff_scan_collection.py 92.30% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #800 +/- ## ========================================== + Coverage 91.92% 92.10% +0.18% ========================================== Files 158 159 +1 Lines 6622 6662 +40 ========================================== + Hits 6087 6136 +49 + Misses 535 526 -9 ``` | [Flag](https://app.codecov.io/gh/GitGuardian/ggshield/pull/800/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GitGuardian) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/GitGuardian/ggshield/pull/800/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GitGuardian) | `92.10% <98.73%> (+0.18%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GitGuardian#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Paul-GitGuardian commented 9 months ago

Thank you for your comments