Closed Paul-GitGuardian closed 9 months ago
Could you add a test please ?
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
2e72fa5
) 92.01% compared to head (026e73f
) 91.92%. Report is 9 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
ggshield/core/git_hooks/ci/previous_commit.py | 0.00% | 2 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Gitlab provides "merged results pipelines" to run in merge requests, as an alternate behavior to the base MR pipelines. However, env variables take unexpected values in these pipelines. Particularly,
CI_COMMIT_BEFORE_SHA
has a non-empty SHA, equal to the last commit pushed. This results in empty commit ranges, meaning CI scans will not detect vulnerabilities in the MR commits.CI_MERGE_REQUEST_TARGET_BRANCH_NAME
is used here, as it is known to be working in merged results requests