Closed Paul-GitGuardian closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
8eb47db
) 91.96% compared to head (056864d
) 92.04%. Report is 4 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
For SCA, after the fix, the output will show filepaths relative to the git repository root, instead of relative to the given directory. Is that a problem?
Currently, tars have two ways to be created in GGShield:
git ls-tree --full-name
, which return filepaths relative to the git rootdirectory.rglob("*")
(wheredirectory
is the argument passed to the command), then returned relative to the directory usingpath.relative_to(directory)
However, the
all
behavior introduces two issues for IAC when calling the command with a Git subdirectory as argument:This PR solves this issue by using the git root for all scans too as the root directory. If the scanned directory isn't a Git repository, the current behavior is maintained.