GitGuardian / ggshield

Find and fix 400+ types of hardcoded secrets and 70+ types of infrastructure-as-code misconfigurations.
https://gitguardian.com
MIT License
1.59k stars 139 forks source link

Remove urlib3<2 pinning #839

Closed agateau-gg closed 6 months ago

agateau-gg commented 6 months ago

The issue between urllib3 >= 2 and vcrpy has been fixed. Update vcrpy and remove the pinning.

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (203302d) 91.87% compared to head (c1fe655) 91.94%. Report is 2 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #839 +/- ## ========================================== + Coverage 91.87% 91.94% +0.06% ========================================== Files 168 168 Lines 6964 6974 +10 ========================================== + Hits 6398 6412 +14 + Misses 566 562 -4 ``` | [Flag](https://app.codecov.io/gh/GitGuardian/ggshield/pull/839/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GitGuardian) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/GitGuardian/ggshield/pull/839/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GitGuardian) | `91.94% <ø> (+0.06%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GitGuardian#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

xblanchot-gg commented 6 months ago

Installed both with and without --skip-lock, works perfectly ! Thanks for the fix !