GitGuardian / ggshield

Find and fix 400+ types of hardcoded secrets and 70+ types of infrastructure-as-code misconfigurations.
https://gitguardian.com
MIT License
1.59k stars 139 forks source link

Xblanchot/sca 1345/add flags on fix available #840

Closed xblanchot-gg closed 6 months ago

xblanchot-gg commented 6 months ago
codecov-commenter commented 6 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8cc5c57) 91.94% compared to head (8630082) 91.95%.

Files Patch % Lines
ggshield/cmd/sca/scan/scan_common_options.py 90.90% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #840 +/- ## ========================================== + Coverage 91.94% 91.95% +0.01% ========================================== Files 168 168 Lines 6974 6987 +13 ========================================== + Hits 6412 6425 +13 Misses 562 562 ``` | [Flag](https://app.codecov.io/gh/GitGuardian/ggshield/pull/840/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GitGuardian) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/GitGuardian/ggshield/pull/840/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GitGuardian) | `91.95% <94.73%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GitGuardian#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

xblanchot-gg commented 6 months ago

@gg-mmill on your comment for the flag names, that would imply an MR both in py-gitguardian and the backend for consistency IMO. So maybe the best is to ask first the product what they think is the best for this.

xblanchot-gg commented 6 months ago

@gg-mmill Last MR, I modified every occurrence of the flags with the new names, and recreated the cassettes.