search

GitGuardian / ggshield

Find and fix 400+ types of hardcoded secrets and 70+ types of infrastructure-as-code misconfigurations.
https://gitguardian.com
MIT License
1.65k stars 147 forks source link

chore(env): # Use py-gitguardian v1.13.0 #845

Closed pierrelalanne closed 8 months ago

pierrelalanne commented 8 months ago

Change required before releasing ggshield 1.24.0

Side effect: pipenv also wanted to upgrade ipython to 8.20.0 which I prevented since this version is incompatible with Python 3.8.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5e709a0) 91.91% compared to head (b934b0d) 91.91%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #845 +/- ## ======================================= Coverage 91.91% 91.91% ======================================= Files 168 168 Lines 6991 6991 ======================================= Hits 6426 6426 Misses 565 565 ``` | [Flag](https://app.codecov.io/gh/GitGuardian/ggshield/pull/845/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GitGuardian) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/GitGuardian/ggshield/pull/845/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GitGuardian) | `91.91% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GitGuardian#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

agateau-gg commented 8 months ago

Side effect: pipenv also wanted to upgrade ipython to 8.20.0 which I prevented since this version is incompatible with Python 3.8.

Interesting. Going to look into why we depend on ipython 🤔.

agateau-gg commented 8 months ago

Side effect: pipenv also wanted to upgrade ipython to 8.20.0 which I prevented since this version is incompatible with Python 3.8.

Interesting. Going to look into why we depend on ipython 🤔.

Ah that's because of the dev dependency on ipdb.