search

GitGuardian / ggshield

Find and fix 400+ types of hardcoded secrets and 70+ types of infrastructure-as-code misconfigurations.
https://gitguardian.com
MIT License
1.65k stars 147 forks source link

Hide vulnerabilities ignored in app #850

Closed Paul-GitGuardian closed 7 months ago

Paul-GitGuardian commented 8 months ago

All vulnerabilities retrieved from the API are now filtered based on their statuses. Ignored vulnerabilities are no longer shown in the text/JSON outputs, for SCA scan all/diff commands.

The implementation is mostly similar to the one for IAC in #800.

codecov-commenter commented 8 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (9a74668) 91.81% compared to head (0b7d36f) 91.79%.

Files Patch % Lines
ggshield/verticals/sca/output/json_handler.py 0.00% 4 Missing :warning:
ggshield/verticals/sca/collection/collection.py 80.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #850 +/- ## ========================================== - Coverage 91.81% 91.79% -0.02% ========================================== Files 167 168 +1 Lines 6975 7007 +32 ========================================== + Hits 6404 6432 +28 - Misses 571 575 +4 ``` | [Flag](https://app.codecov.io/gh/GitGuardian/ggshield/pull/850/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GitGuardian) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/GitGuardian/ggshield/pull/850/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GitGuardian) | `91.79% <85.36%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GitGuardian#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

xblanchot-gg commented 7 months ago

Thanks, I tested it using staging and it works perfectly ! I only have some small comments regarding the tests.